This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [AArch64] use stack symbol provided by linker for nosys
Yes, old fashion habits )
Alex
On Tue, Aug 15, 2017 at 4:57 PM, Tamar Christina
<Tamar.Christina@arm.com> wrote:
>> -----Original Message-----
>> From: Alexander Fedotov [mailto:alfedotov@gmail.com]
>> Sent: 15 August 2017 14:35
>> To: Tamar Christina
>> Cc: Szabolcs Nagy; newlib@sourceware.org; nd
>> Subject: Re: [AArch64] use stack symbol provided by linker for nosys
>>
>> Yes, there is a typo - it should be ARM_RDI_MONITOR
>
> Think you forgot to submit it as a git format-patch :)
>
>>
>> Thanks !
>>
>> On Tue, Aug 15, 2017 at 3:46 PM, Tamar Christina
>> <Tamar.Christina@arm.com> wrote:
>> >> > diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
>> >> > index
>> >> > 3bf0278..0c669d9 100644
>> >> > --- a/libgloss/aarch64/crt0.S
>> >> > +++ b/libgloss/aarch64/crt0.S
>> >> > @@ -83,7 +83,7 @@
>> >> > FUNC_START _start
>> >> >
>> >> > /* Start by setting up a stack */
>> >> > -
>> >> > +#ifdef ARM_RDI_MONITOR
>> >>
>> >> i think this should match
>> >>
>> >> ...
>> >> > +#ifdef ARM_RDP_MONITOR
>> >
>> > We don't define ARM_RDP_MONITOR in AArch64, so this should be
>> ARM_RDI_MONITOR.
>> >
>> >>
>> >> this.
>> >>
>> >> > .LC0:
>> >> > GEN_DWORD HeapBase
>> >
>>
>>
>>
>> --
>> Best regards,
>> AF
--
Best regards,
AF
From 041c8b2d571a96c1ebecb7cba6e8afb2d96064bb Mon Sep 17 00:00:00 2001
From: Alexander Fedotov-B55613 <b55613@freescale.com>
Date: Tue, 15 Aug 2017 17:01:05 +0300
Subject: [PATCH] fix typo in AArch64 crt0
---
libgloss/aarch64/crt0.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libgloss/aarch64/crt0.S b/libgloss/aarch64/crt0.S
index 0c669d9..cc7e84d 100644
--- a/libgloss/aarch64/crt0.S
+++ b/libgloss/aarch64/crt0.S
@@ -243,7 +243,7 @@ FUNCTION (_cpu_init_hook):
ret
.align 3
-#ifdef ARM_RDP_MONITOR
+#ifdef ARM_RDI_MONITOR
.LC0:
GEN_DWORD HeapBase
#else
--
2.7.4