This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH 1/4] Importing strtoimax inttypes method from FreeBSD.
Yes, I will commit the thrid party unmodified code first, then i will
commit the modified code.
On Wed, Aug 2, 2017 at 7:25 PM, Gedare Bloom <gedare@rtems.org> wrote:
> On Wed, Aug 2, 2017 at 7:04 AM, Corinna Vinschen <vinschen@redhat.com> wrote:
>> On Aug 2 08:49, Aditya Upadhyay wrote:
>>> ---
>>> newlib/libc/include/inttypes.h | 12 +++
>>> newlib/libc/stdlib/Makefile.am | 1 +
>>> newlib/libc/stdlib/strtoimax.c | 167 +++++++++++++++++++++++++++++++++++++++++
>>
>> All 4 patches applied.
>>
>> I made a few minor formatting changes in terms of whitespaces and
>> missing empty lines between functions. Please compare what I commited
>> with your local patch to see the differences.
>>
> Thanks. There were no empty lines between functions in the original
> BSD source. However, since the original source was not submitted
> separately from the modification to make it useful, this is hard to
> see. Best to leave it as you have pushed it I suppose.
>
> Aditya, if there are more patches in the future please first provide a
> commit with the unmodified BSD file, and then a second commit to
> modify the file and to add it to the build system. I neglected to
> follow-up on this procedure with you, but it is a good way to ensure
> tight synchronization with upstream sources.
>
> -Gedare
>
>>
>> Thanks,
>> Corinna
>>
>> --
>> Corinna Vinschen
>> Cygwin Maintainer
>> Red Hat