This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Procedure for Patches Merging FreeBSD Code
- From: Joel Sherrill <joel dot sherrill at oarcorp dot com>
- To: "newlib at sourceware dot org" <newlib at sourceware dot org>, aditya upadhyay <aadit0402 at gmail dot com>
- Date: Wed, 26 Jul 2017 09:59:41 -0500
- Subject: Procedure for Patches Merging FreeBSD Code
- Authentication-results: sourceware.org; auth=none
Hi
Gedare, Aditya, and I were discussing that it is useful
during development to have a git branch with a patch
series that adds the unmodified FreeBSD files followed
by a patch series that adds them to the build system
and makes them work. Then you can easily review the
differences against the original source.
Would it be desirable for patches submitted to newlib
to follow this pattern? Or should Aditya submit a
single patch series including the addition and
any modifications?
For sure, the addition change can only add the source
files and not touch the build system. Otherwise
git bisect will break. That can't be allowed if
avoidable.
Thanks.
--joel