Re: [PATCH v2 3/3] Add ffsl(), ffsll(), fls(), flsl(), flsll()

[Corinna Vinschen <vinschen at redhat dot com>]

On Jul  5 10:54, Sebastian Huber wrote:
> Use compiler builtin for ffs().  Remove duplicate implementation from
> Cygwin.
> 
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
>  newlib/libc/misc/ffs.c         | 14 ++-------
>  newlib/libc/string/Makefile.am |  5 ++++
>  newlib/libc/string/Makefile.in | 64 +++++++++++++++++++++++++++++++++---------
>  newlib/libc/string/ffsl.c      | 34 ++++++++++++++++++++++
>  newlib/libc/string/ffsll.c     | 34 ++++++++++++++++++++++
>  newlib/libc/string/fls.c       | 38 +++++++++++++++++++++++++
>  newlib/libc/string/flsl.c      | 38 +++++++++++++++++++++++++
>  newlib/libc/string/flsll.c     | 38 +++++++++++++++++++++++++
>  winsup/cygwin/syscalls.cc      | 22 ---------------
>  9 files changed, 240 insertions(+), 47 deletions(-)
>  create mode 100644 newlib/libc/string/ffsl.c
>  create mode 100644 newlib/libc/string/ffsll.c
>  create mode 100644 newlib/libc/string/fls.c
>  create mode 100644 newlib/libc/string/flsl.c
>  create mode 100644 newlib/libc/string/flsll.c

Patchset looks good, please push.

For Cygwin we also need to add the new fls* entry points to
common.din and to the docs.  I'll do that later, when you 
pushed your patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature