Re: Adding Methods related to inttypes.h

[Sebastian Huber <sebastian dot huber at embedded-brains dot de>]

On 14/06/17 10:44, Corinna Vinschen wrote:

> On Jun 14 07:42, Sebastian Huber wrote:
> > On 13/06/17 21:03, aditya upadhyay wrote:
> >
> > > Hello Developers,
> > >
> > > I have ported the methods what are declared inside the inttypes.h
> > > header file from freebsd. I am requesting you to please review the
> > > code.
> > >
> > > I am not able to push the code of ccoshl.c in my forked repo. It is
> > > saying fatal error. I do not know how to apply the signature.asc file.
> > > Please have a look on my issue.
> > > [...]
> > >    newlib/libc/Makefile.am          |   4 +-
> > >    newlib/libc/inttypes/Makefile.am |  24 +++++++
> > >    newlib/libc/inttypes/imaxabs.c   |  44 ++++++++++++
> > >    newlib/libc/inttypes/imaxdiv.c   |  53 ++++++++++++++
> > >    newlib/libc/inttypes/strtoimax.c | 144 +++++++++++++++++++++++++++++++++++++
> > >    newlib/libc/inttypes/strtoumax.c | 135 ++++++++++++++++++++++++++++++++++
> > >    newlib/libc/inttypes/wcstoimax.c | 151 +++++++++++++++++++++++++++++++++++++++
> > >    newlib/libc/inttypes/wcstoumax.c | 144 +++++++++++++++++++++++++++++++++++++
> > These functions should probably go into "newlib/libc/stdlib" just like on
> > FreeBSD and NetBSD. Where does this "inttypes" directory come from?
> ACK.
>
> Also, newlib already has functions strtoll, strtoull, wcstoll, wcstoull.
> So the aliasing to strtoimax, etc, seems like a bad idea.  In theory,
> all we need is an aliasing from strtoll to strtoumax, etc, in the existing
> sources.

As a background information, this is part of a Google Summer of Code 
project:

https://docs.google.com/document/d/1_eo87eOiHmIHokfsgFYY3F98FNmorpVTm4AI1WE-iKo/edit

You can use __strong_alias from <sys/cdefs.h> to create an alias from 
strtoll to strtoumax. We should make sure that the types have the same 
size with a compile-time assertion.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.