This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH, ARM] Fix minor issues in memchr NEON implementation

From: Prakhar Bahuguna <prakhar dot bahuguna at arm dot com>
To: newlib at sourceware dot org
Cc: nd at arm dot com
Date: Fri, 2 Jun 2017 11:22:56 +0100
Subject: [PATCH, ARM] Fix minor issues in memchr NEON implementation
Authentication-results: sourceware.org; auth=none
Authentication-results: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com;
Nodisclaimer: True
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

The NEON-optimised implementation of memchr has a couple of minor issues - it
does not mask off the higher bits of the input character, and it uses a signed
comparison instead of unsigned within the smallstr loop. This patch addresses
both of these issues.

ChangeLog:

2017-06-02  Prakhar Bahuguna  <prakhar.bahuguna@arm.com>

	* libc/machine/arm/memchr.S: Add and instruction to mask off all but
	the lowest byte.
	Change blt to blo.

Okay for master?

-- 

Prakhar Bahuguna

Attachment: 0001-Fix-minor-issues-in-memchr-NEON-implementation.patch
Description: Text document

Follow-Ups:
- Re: [PATCH, ARM] Fix minor issues in memchr NEON implementation
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]