This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH][MSP430] Fix return code error in simulator implemenations of write.c.
- From: Nick Clifton <nickc at redhat dot com>
- To: Martin Young <martin dot y at somniumtech dot com>, newlib at sourceware dot org
- Date: Fri, 26 May 2017 11:36:53 +0100
- Subject: Re: [PATCH][MSP430] Fix return code error in simulator implemenations of write.c.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=nickc at redhat dot com
- Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E15E67F3FA
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E15E67F3FA
- References: <CAAcP3OMWi+iQRwBjfMhrMQ0yTd_emX=VatPOvJ8YB2UodgRPmQ@mail.gmail.com>
Hi Martin,
> In the MSP430 simulator implementation of write() in write.c the wrong
> local is used as the return code (it's returning the result of the
> last invocation of write_chunk() (variable c) rather than the
> aggregate write size (variable rv). This causes issues for users of
> write().
>
> Patch included as attachment to avoid whitespace issues.
Thanks very much for reporting this problem, and for providing a fix.
I have checked your patch in, so the write() function should work
properly from now on.
Cheers
Nick