This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 05/23/2017 04:23 AM, Sebastian Huber wrote:
Would you please explain why !_POSIX_SOURCE being replaced with __BSD_VISIBLE rather than, for example, !__POSIX_VISIBLE? That is, you seem to not only be updating to sys/features.h macro names, but also shifting exactly how the gate is done. (I'm not saying it is necessarily incorrect, just that the explanation does not mention the logic change. The two are not logical opposites, so an implication is that the original gate of POSIX is not really the right one.)The Termios header <sys/_termios.h> used _POSIX_SOURCE directly to determine if a thing should be exposed to the user. This circumvented the feature mechanisms of <sys/cdefs.h>.
Craig
Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de> --- newlib/libc/sys/rtems/include/sys/_termios.h | 46 ++++++++++++++-------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/newlib/libc/sys/rtems/include/sys/_termios.h b/newlib/libc/sys/rtems/include/sys/_termios.h index c8fe054da..2e7cc36c2 100644 --- a/newlib/libc/sys/rtems/include/sys/_termios.h +++ b/newlib/libc/sys/rtems/include/sys/_termios.h @@ -42,15 +42,15 @@ */ #define VEOF 0 /* ICANON */ #define VEOL 1 /* ICANON */ -#ifndef _POSIX_SOURCE +#if __BSD_VISIBLE ...
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |