This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: newlib-2.5.0 bug report

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Wed, 26 Apr 2017 10:30:58 +0200
Subject: Re: newlib-2.5.0 bug report
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2F4AB7F4AB
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F4AB7F4AB
References: <HE1PR0801MB186596D0E35138E1F655FF6D9C1E0@HE1PR0801MB1865.eurprd08.prod.outlook.com>
Reply-to: newlib at sourceware dot org

On Apr 25 18:03, David Binderman wrote:
> Hello there,
> 
> newlib-2.5.0/newlib/libc/sys/linux/iconv/gconv_trans.c:196]: (warning) Char literal compared with pointer 'newp.fname'. Did you intend to dereference it?
> 
> Source code is
> 
>               strcpy ((char *) newp->fname, runp->name);
>               while(newp->fname != '\0') newp->fname++;
> 
> Maybe better code
> 
>               strcpy ((char *) newp->fname, runp->name);
>               while(*(newp->fname) != '\0') newp->fname++;
> 
> Regards
> 
> David Binderman

Makes sense.  Please send a patch.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- newlib-2.5.0 bug report
  - From: David Binderman

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]