This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Uninitialized structure in printing functions

From: Corinna Vinschen <vinschen at redhat dot com>
To: Giacomo Tesio <giacomo at tesio dot it>
Cc: newlib at sourceware dot org
Date: Wed, 26 Apr 2017 10:24:27 +0200
Subject: Re: Uninitialized structure in printing functions
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=vinschen at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C54217F4D3
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C54217F4D3
References: <CAHL7psH=7EPatUD0DgncqvqMdsXapmRem=eM-NYY9sGbs_oN-g@mail.gmail.com>
Reply-to: newlib at sourceware dot org

On Apr 21 19:03, Giacomo Tesio wrote:
> Hi, during the port to Jehanne, I had issues with the uninitialized
> uio structure in several printing functions.
> 
> The attached patch fixes them.

I'm puzzled what problem you're solving.

I inspected the code in question and the uio structure is always filled
with values for all three members before using it.  Setting uio to 0
in all these places looks gratuitous.

Can you please explain what exactly you're observing and how setting
uio to all 0 solved this problem?  

Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: Uninitialized structure in printing functions
  - From: Giacomo Tesio

References:
- Uninitialized structure in printing functions
  - From: Giacomo Tesio

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]