This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: fopen() behavior: File positioning in append mode
- From: Craig Howland <howland at LGSInnovations dot com>
- To: <newlib at sourceware dot org>
- Date: Fri, 3 Feb 2017 10:11:13 -0500
- Subject: Re: fopen() behavior: File positioning in append mode
- Authentication-results: sourceware.org; auth=none
- References: <23012be5-2810-3215-da19-374c7c081b68@gmx.de>
On 02/03/2017 05:59 AM, Stefan Heinzmann wrote:
Hi,
I am unsure what the behavior of fopen() should be when the "a+" mode is
given. The source for this is in file newlib/libc/stdio/fopen.c
Mode a+ translates to open() flags O_RDWR|O_CREAT|O_APPEND according to the
POSIX standard. This would set the file position to the beginning of the file.
The file position would be relevant only to read operations, since the
O_APPEND flag causes writes to happen at the file end in any case.
However, fopen() seems to set the file position to the end in this case, by
calling fseek() explicitly. The consequence is that read operations also
happen at the file end. I don't understand why this is done. Wouldn't it be
more useful to omit the call to fseek(), or to restrict it to the write-only
case?
The C standard doesn't seem to be clear here. Does it actually specify what
the result of ftell() should be immediately after calling fopen()? I seem to
be unable to find conclusive text.
Thanks
Stefan
See C99 section 7.19.3, where it defines that, if a file does support
positioning requests, the initial position is 0 unless the file is opened in
append mode. If the file is opened in append mode, then the initial position is
implementation defined. So there is conclusive text, but it does allow a choice.
I suggest that the newlib implementation choice makes sense. The "a" mode
opens for writing only at the end of the file. Using a+ adds the ability to
read, also. Since it is based on "a", starting at the end makes sense. The
user could also choose r+--based on r--in which case a reasonable assumption
(and the required behavior) is that it would start at 0 for read. This line of
reasoning (which I thought of before checking the code) is borne out by the
actual implementation--the fseek happens if "a" was used.
Craig