This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, newlib] Allow locking routine to be retargeted


On 01/11/2017 12:48 PM, Thomas Preudhomme wrote:
On 11/01/17 16:46, Craig Howland wrote:
On 01/11/2017 11:09 AM, Thomas Preudhomme wrote:
Here you are. It has worked fine with my limited testing. I welcome all
feedback about the testing you can throw at this.

Best regards,

Thomas

+TRAD_SYNOPSIS
+    void __retarget_lock_init(<[lock_ptr]>)
+    _LOCK_T * <[lock_ptr]>;
+
+    void __retarget_lock_init_recursive(<[lock_ptr]>)
+    _LOCK_T * <[lock_ptr]>;
...


Please leave out the TRAD_SYNOPSIS section.  The documentation tools ignore
them.  It is not worth the time to attempt to maintain them. (While it's not
necessarily worth the effort to go back and remove them from all the legacy
files, it makes the most sense to not put them in new things so that going
forward there is not quite as much clutter.)

Very well. How about the attached patch?

Best regards,

Thomas
That aspect of it looks good.  Thank you.
Someone else is better suited for commenting on the real contents of the patch, however.
Craig


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]