This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH] newlib-stdint.h: Remove 32 bit longs
- From: Andy Ross <andrew dot j dot ross at intel dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: newlib at sourceware dot org
- Date: Mon, 22 Aug 2016 09:19:06 -0700
- Subject: Re: [PATCH] newlib-stdint.h: Remove 32 bit longs
- Authentication-results: sourceware.org; auth=none
- References: <e7907443-eea0-87b5-87ba-fc34aa90c387@intel.com>
Same code. Includes an attempt to format a change log entry in a more
gcc-friendly way. I'm new here.
>From c208b51fb55c6758c1059dfaee398c27da398e9d Mon Sep 17 00:00:00 2001
From: Andy Ross <andrew.j.ross@intel.com>
Date: Fri, 19 Aug 2016 09:40:42 -0700
Subject: [PATCH] newlib-stdint.h: Remove 32 bit longs
This would make __INT32_TYPE__ a "long" instead of an "int", which
would then percolate down in newlib's own headers into a typedef for
int32_t. Which is wrong. Newlib's headers, if __INT32_TYPE__ were
not defined, actually would chose an int for this type. The comment
that newlib uses a 32 bit long appears to be a lie, perhaps
historical.
* gcc/config/newlib-stdint.h: synchronize 32 bit type macros with
newlib's own headers.
Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
---
gcc/config/newlib-stdint.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/gcc/config/newlib-stdint.h b/gcc/config/newlib-stdint.h
index eb99556..0275948 100644
--- a/gcc/config/newlib-stdint.h
+++ b/gcc/config/newlib-stdint.h
@@ -22,10 +22,9 @@ a copy of the GCC Runtime Library Exception along with this program;
see the files COPYING3 and COPYING.RUNTIME respectively. If not, see
<http://www.gnu.org/licenses/>. */
-/* newlib uses 32-bit long in certain cases for all non-SPU
- targets. */
+/* newlib used to use a 32-bit long, no longer */
#ifndef STDINT_LONG32
-#define STDINT_LONG32 (LONG_TYPE_SIZE == 32)
+#define STDINT_LONG32 0
#endif
#define SIG_ATOMIC_TYPE "int"
--
2.7.4