This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Locale Build Failure #2


On Aug 16 14:35, Craig Howland wrote:
> On 08/16/2016 02:17 PM, Corinna Vinschen wrote:
> > -char *
> > +const char *
> >   _DEFUN_VOID (__locale_ctype_ptr)
> >   {
> >     /* Only check if the current thread/reent has a locale.  ctype_ptr is unused
> > @@ -992,7 +992,7 @@ _DEFUN_VOID (__locale_ctype_ptr)
> >   				 : __ctype_ptr__;
> >   }
> With the recent general change to drop original K&R-style, as long is this
> is being edited, how about also
> -_DEFUN_VOID (__locale_ctype_ptr)
> +__locale_ctype_ptr(void)
> (more readable, compares more easily against the "char *__locale_ctype_ptr
> (void);" prototype)?

I didn't intend to change existing function definitions but, well,
yes, why not?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]