Re: [PATCH] Phoenix-RTOS: Add caddr_t definition to <sys/types.h>.

[Jakub Sejdak <jakub dot sejdak at phoesys dot com>]

> libc/include/sys/types.h provides all the types already.  why do you
> need to duplicate it ?  there's a ton of such examples in the pheonix
> codebase.

Because we needed to move few type definitions to kernel, thus now
types.h is not identical as one in common newlib space. The same rule
applies to other headers that are copied to sys/phoenix/sys private
directory.

> i don't see how that's relevant to an open source project

I said this, because someone before proposed me to have all
definitions in newlib, not in kernel, and include libc headers into
kernel adding #ifdef _KERNEL or similar where appropriate. This is not
an option, because of our policy.
I copy standard headers to our private directory only when it is
necessary. It's not a problem for newlib in general, since it has no
impact on all other projects.

> I just noticed, that this patch was unnecessary, beacuse caddr_t was
> already there. Now it is duplicated.
> If possible please revert it. If you wish I can send a second patch to
> revert it.

Just to remind, in case it was lost in our discussion.

2016-06-28 15:01 GMT+02:00 Mike Frysinger <vapier@gentoo.org>:
> On 28 Jun 2016 13:09, Jakub Sejdak wrote:
>> As I said in the initial commit, we prefer to avoid duplication of
>> type definitions between kernel and newlib.
>
> libc/include/sys/types.h provides all the types already.  why do you
> need to duplicate it ?  there's a ton of such examples in the pheonix
> codebase.
>
>> We also don't want to include newlib headers in kernel (it should
>> compile without newlib). This is our company policy and I cannot do
>> anything about that.
>
> i don't see how that's relevant to an open source project
> -mike

-- 
Jakub Sejdak
Software Engineer
Phoenix Systems (www.phoesys.com)
+48 608 050 163