This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Feature test macros: ctermid, cuserid

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Sat, 21 May 2016 18:50:34 +0200
Subject: Re: [PATCH] Feature test macros: ctermid, cuserid
Authentication-results: sourceware.org; auth=none
References: <CAG1-Us098Ap_h1QSxoE1iLgv=sf6McxKiTqW-JgB5JDQ6u5=0g at mail dot gmail dot com> <1463782304-12104-1-git-send-email-yselkowi at redhat dot com>
Reply-to: newlib at sourceware dot org

On May 20 17:11, Yaakov Selkowitz wrote:
> The proper location for these functions has always been <stdio.h>, however
> XPG4 and SUSv2 did mandate a duplicate declaration in <unistd.h>.  cuserid
> was dropped in SUSv3 (it was marked legacy since XPG4) and the ctermid
> declaration in <unistd.h> was made optional and obsolete in SUSv4.
> 
> Fixes: https://cygwin.com/ml/cygwin/2016-05/msg00002.html

Thanks, just one point of discussion:

> +#if __POSIX_VISIBLE
>  #ifdef __CYGWIN__
>  #define L_ctermid       16
>  #endif

I think we should get rid of the ifdef CYGWIN.  This is a POSIX mandated
macro (for some given value of POSIX) so we should simply enable it for
all targets.  If any system has a particular wish to change the numbers
we can adapt.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

Follow-Ups:
- Re: [PATCH] Feature test macros: ctermid, cuserid
  - From: Joel Sherrill

References:
- [PATCH] Feature test macros: ctermid, cuserid
  - From: Yaakov Selkowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]