This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 11/18] Provide POSIX defined fsblkcnt_t and fsfilcnt_t




On 15/04/16 14:56, Corinna Vinschen wrote:
On Apr 15 13:44, Sebastian Huber wrote:
>Signed-off-by: Sebastian Huber<sebastian.huber@embedded-brains.de>
>---
>  newlib/libc/include/sys/_types.h       |  8 ++++++++
>  newlib/libc/include/sys/types.h        |  6 ++++++
>  winsup/cygwin/include/cygwin/types.h   | 12 ------------
>  winsup/cygwin/include/machine/_types.h |  8 ++++++++
>  4 files changed, 22 insertions(+), 12 deletions(-)
>[...]
>diff --git a/winsup/cygwin/include/machine/_types.h b/winsup/cygwin/include/machine/_types.h
>index f09f1ef..7bc6a21 100644
>--- a/winsup/cygwin/include/machine/_types.h
>+++ b/winsup/cygwin/include/machine/_types.h
>@@ -22,6 +22,14 @@ typedef __int32_t __blksize_t;
>  #define __machine_dev_t_defined
>  typedef __uint32_t __dev_t;
> >+#define __machine_fsblkcnt_t_defined
>+/* Keep as is.  32 bit on i386, 64 bit on x86_64. */
>+typedef unsigned long fsblkcnt_t;
>+
>+#define __machine_fsfilcnt_t_defined
>+/* Keep as is.  32 bit on i386, 64 bit on x86_64. */
>+typedef unsigned long fsfilcnt_t;
Typo:  The leading underscores were missing in the type names.
I fixed that on the fly while commiting this change.

All patches applied.  I added a small followup patch to get rid of the
usage of _mode_t in Cygwin in favor of __mode_t.

Thanks a lot for the fast integration. I will send the next patches next week with a couple of non-POSIX types and a rework of <machine/endian.h>.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]