This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [PATCH 001/114] Add initial port for Phoenix-RTOS.
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: Jakub Sejdak <jakub dot sejdak at phoesys dot com>
- Cc: newlib at sourceware dot org
- Date: Fri, 15 Apr 2016 09:06:12 +0200
- Subject: Re: [PATCH 001/114] Add initial port for Phoenix-RTOS.
- Authentication-results: sourceware.org; auth=none
- References: <1460370132-4880-1-git-send-email-jakub dot sejdak at phoesys dot com> <570CBA29 dot 2040200 at embedded-brains dot de> <CAFvk=0vKpZ=fVOHv-k46B3rOMrDP8p1K1eRA4O0oCD=Bf3Uztg at mail dot gmail dot com> <CAFvk=0tyD=crt5v77xzkzyt7MTXdXCTNZ7w4D10NKq32iE6=8g at mail dot gmail dot com>
Hello Jakub,
On 15/04/16 08:46, Jakub Sejdak wrote:
Hi again,
Just to be sure that I understood you correctly - should I send any
new patches or will you handle this alone?
I can see that you already have a lot of work, but can you
approximately estimate when will those patcches be applied?
I am not a Newlib maintainer and added just my two cents to this topic.
Thank,
Jakub Sejdak
2016-04-12 12:39 GMT+02:00 Jakub Sejdak <jakub.sejdak@phoesys.com>:
Hi Sebastian,
Ad 1) I actually copied this license header from some other existing
file and changed first line to include our URL.
Feel free to edit it so it could fit newlib licensing. But it still
would be nice to have this URL somewhere.
For Newlib a 2-clause or 3-clause BSD license would be fine.
Ad 2) The idea behind copying some of the standard headers was to
avoid duplicating some definitions in newlib and in our kernel.
So for example struct tm is defined directly in kernel header and
included in <time.h> by <phoenix/time.h>.
I am aware, that "duplication" of standard structures in libc and
kernel is a general approach, but we thought that one definition would
work best for us, since we are in very active development of
Phoenix-RTOS.
Would that be a big problem? I'm open for discussion.
Why not use the user space header in your kernel? Maybe use a _KERNEL
define like in BSD systems.
How is time_t defined on your system?
Ad 3) Common network headers sounds like a good plan. I don't remember
adding any huge changes to those files. They are pretty much just
copies from Linux port.
We should evaluate if we should move the standard network headers to the
general part of Newlib.
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.