Re: [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t

[Sebastian Huber <sebastian dot huber at embedded-brains dot de>]

----- Corinna Vinschen <vinschen@redhat.com> schrieb:
> On Apr 13 19:15, Sebastian Huber wrote:
> > 
> > ----- Corinna Vinschen <vinschen@redhat.com> schrieb:
> > > On Apr 13 15:40, Sebastian Huber wrote:
> > > > 
> > > > 
> > > > On 13/04/16 15:24, Corinna Vinschen wrote:
> > > > >diff --git a/winsup/cygwin/include/cygwin/types.h b/winsup/cygwin/include/cygwin/types.h
> > > > >index bdf4085..f9ed4b6 100644
> > > > >--- a/winsup/cygwin/include/cygwin/types.h
> > > > >+++ b/winsup/cygwin/include/cygwin/types.h
> > > > >@@ -32,19 +32,8 @@ typedef struct timespec timespec_t;
> > > > >  typedef struct timespec timestruc_t;
> > > > >  #endif /*__timestruc_t_defined*/
> > > > >-#ifndef __off_t_defined
> > > > >-#define __off_t_defined
> > > > >-typedef __off_t off_t;
> > > > >-#endif /*__off_t_defined*/
> > > > >-
> > > > 
> > > > What I don't understand is, if you remove the off_t definition here, via
> > > > which include do you get it then? The <sys/types.h> seems to be not included
> > > > by cygwin/types.h.
> > > 
> > > No, sys/types.h includes cygwin/types.h.  We may want to get rid of this
> > > at one point in favor of only maintaining machine/_types.h, I guess....
> > 
> > Ok, how do you want to proceed? Should I integrate your changes into
> > my patch set or do you want to add it yourself?
> 
> I'll commit it myself, but I was asking you for a review first.

It looks good now that I understood how the <sys/types.h> and <cygwin/types.h> are connected.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschÃftliche Mitteilung im Sinne des EHUG.