Re: [PATCH v3 2/2] Add BSD guards for off_t, dev_t, uid_t, and gid_t

[Corinna Vinschen <vinschen at redhat dot com>]

On Apr 13 15:29, Sebastian Huber wrote:
> 
> 
> On 13/04/16 15:24, Corinna Vinschen wrote:
> >On Apr 13 13:10, Sebastian Huber wrote:
> >>>Copy definitions of off_t, dev_t, uid_t, and gid_t verbatim from latest
> >>>FreeBSD <sys/types.h>.
> >Patches look good.
> >
> >Below is a followup patch to get rid of Cygwin special handling.
> >
> >Basically it introduces machine/_types.h in Cygwin, plus it also
> >handles key_t just like the other types in _types.h and types.h.
> >
> >It works AFAICS, but I'd be glad if you could take a look if I
> >didn't screw up something.
> >
> >Independently of the below patch, what about mode_t?  Right now it's
> >an RTEMS special:
> >
> >   #if defined(__rtems__)
> >   typedef _mode_t mode_t;
> >   #endif
> >
> >Shouldn't we generalize this one as well?
> 
> I have a couple of patches in the queue that addresses these issues as well.
> I wanted to wait before the current set is committed. I will rebase to
> whatever you commit.

Ok, cool.  Can you take a critical look into my patch, please?
Does it look ok to you?


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature