Re: [PATCH v2] math: guard BSD finite/isinf/isnan functions properly in math.h

[Corinna Vinschen <vinschen at redhat dot com>]

On Apr  4 14:27, Yaakov Selkowitz wrote:
> Now that we have properly functioning feature test macros, the BSD
> floating-point classification functions can go into math.h instead of
> the non-standard ieeefp.h, and not under the C99 guard:
> 
> http://man7.org/linux/man-pages/man3/finite.3.html
> 
> The isnan function was in earlier versions of SUS but removed starting with
> POSIX.1-2001, compare:
> 
> http://pubs.opengroup.org/onlinepubs/007908799/xsh/math.h.html
> http://pubs.opengroup.org/onlinepubs/009695399/basedefs/math.h.html
> 
> Note that the isinf and isnan functions (but not the variants) conflict
> with functions by the same name in C++11, hence they (and only they)
> need to be hidden:
> 
> https://sourceware.org/git/?p=glibc.git;a=commit;h=d9b965fa56350d6eea9f7f438a0714c7ffbb183f
> https://sourceware.org/git/?p=glibc.git;a=commit;h=3c47c83a9730c20e602694505b9278c25637b0d0

Looks good, please apply.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature