This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add simple versions of random() and srandom()

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Wed, 23 Mar 2016 20:30:10 +0100
Subject: Re: [PATCH] Add simple versions of random() and srandom()
Authentication-results: sourceware.org; auth=none
References: <1458754730-13691-1-git-send-email-joel at rtems dot org> <56F2D642 dot 7060902 at cygwin dot com> <56F2E3C6 dot 40701 at oarcorp dot com>
Reply-to: newlib at sourceware dot org

On Mar 23 13:43, Joel Sherrill wrote:
> 
> 
> On 3/23/2016 12:45 PM, Yaakov Selkowitz wrote:
> >On 2016-03-23 12:38, Joel Sherrill wrote:
> >>--- a/newlib/libc/include/stdlib.h
> >>+++ b/newlib/libc/include/stdlib.h
> >>@@ -226,6 +226,12 @@ unsigned short *
> >>   _VOID  _EXFUN(srand48,(long));
> >>   _VOID  _EXFUN(_srand48_r,(struct _reent *, long));
> >>   #endif /* __SVID_VISIBLE || __XSI_VISIBLE */
> >>+#if __SVID_VISIBLE || __XSI_VISIBLE >= 4 || __BSD_VISIBLE
> >
> >Please review my previous comment on this.
> 
> Is this the desired guard?
> 
> #if __MISC_VISIBLE || __XSI_VISIBLE >= 500

#if __MISC_VISIBLE || __XSI_VISIBLE >= 4 seems more correct, but
I have no idea how to get this into the documentation.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH] Add simple versions of random() and srandom()
  - From: Joel Sherrill
- Re: [PATCH] Add simple versions of random() and srandom()
  - From: Yaakov Selkowitz
- Re: [PATCH] Add simple versions of random() and srandom()
  - From: Joel Sherrill

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]