This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix "/*" within comment warning

From: Yaakov Selkowitz <yselkowitz at cygwin dot com>
To: newlib at sourceware dot org
Date: Mon, 21 Mar 2016 10:09:44 -0500
Subject: Re: [PATCH] Fix "/*" within comment warning
Authentication-results: sourceware.org; auth=none
References: <1458558472-24672-1-git-send-email-sebastian dot huber at embedded-brains dot de> <20160321114442 dot GS3422 at calimero dot vinschen dot de> <56F0011B dot 6030603 at redhat dot com> <20160321145015 dot GA7179 at calimero dot vinschen dot de>

On 2016-03-21 09:50, Corinna Vinschen wrote:

On Mar 21 09:11, Yaakov Selkowitz wrote:

On 2016-03-21 06:44, Corinna Vinschen wrote:

+/* These types are required by netinet/ *.h on Cygwin */
  #if __BSD_VISIBLE || defined(__CYGWIN__)
  #ifndef _BSDTYPES_DEFINED
  /* also defined in mingw/gmon.h and in w32api/winsock[2].h */


Apart from the comment patch, do we really need "|| defined(__CYGWIN__)"
here?


The comment explains the very reason why those types are always needed.


The comment doesn't really explain it.  Why is it needed for Cygwin
if it's not needed for glibc?


Because our netinet headers are from BSD and use BSD types.

--
Yaakov

Follow-Ups:
- Re: [PATCH] Fix "/*" within comment warning
  - From: Corinna Vinschen

References:
- [PATCH] Fix "/*" within comment warning
  - From: Sebastian Huber
- Re: [PATCH] Fix "/*" within comment warning
  - From: Corinna Vinschen
- Re: [PATCH] Fix "/*" within comment warning
  - From: Yaakov Selkowitz
- Re: [PATCH] Fix "/*" within comment warning
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]