Re: [PATCH] Fix "/*" within comment warning

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 21 12:07, Sebastian Huber wrote:
> Signed-off-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
> ---
>  newlib/libc/include/sys/types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/newlib/libc/include/sys/types.h b/newlib/libc/include/sys/types.h
> index 52530c5..33c3e3e 100644
> --- a/newlib/libc/include/sys/types.h
> +++ b/newlib/libc/include/sys/types.h
> @@ -90,7 +90,7 @@ typedef	quad_t *	qaddr_t;
>  #  define	quad		quad_t
>  #endif
>  
> -/* These types are required by netinet/*.h on Cygwin */
> +/* These types are required by netinet/ *.h on Cygwin */
>  #if __BSD_VISIBLE || defined(__CYGWIN__)
>  #ifndef _BSDTYPES_DEFINED
>  /* also defined in mingw/gmon.h and in w32api/winsock[2].h */

Apart from the comment patch, do we really need "|| defined(__CYGWIN__)"
here?

In glibc's sys/types.h, these types are guarded by __USE_MISC, that
would mean __MISC_VISIBLE for us.

Many files on Linux are using these types as well.  All of them I looked
up include sys/types.h, but they don't make suer __USE_MISC is defined.

Yaakov?


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature