Re: [PATCH 5/5] Add arc4random() etc. from OpenBSD 5.8

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 18 19:49, Sebastian Huber wrote:
> 
> 
> ----- Am 18. Mrz 2016 um 17:25 schrieb Corinna Vinschen vinschen@redhat.com:
> 
> > On Mar 18 15:48, Sebastian Huber wrote:
> >> 
> >> 
> >> On 18/03/16 14:50, Corinna Vinschen wrote:
> >> >On Mar 18 12:28, Corinna Vinschen wrote:
> >> >>>On Mar 18 11:49, Sebastian Huber wrote:
> [...] 
> >> I am not sure if we should add the arc4random_stir() and
> >> arc4random_addrandom() functions, since this may lead configure scripts to
> >> enable their use. With the getentropy() system call I am not sure if this is
> >> harmful.
> > 
> > They are required for backward compatiblity.  I also don't understand
> > why they should be harmful.  Are they harmful on OpenBSD?
> 
> They no longer exist on OpenBSD and were removed 2013 via this message:
> 
> "Remove arc4random_stir() and arc4random_addrandom(), which none should
> be using directly.  Well, a few rare people cloned it upstream and it
> will take a bit of time for them to learn."
> 
> http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/crypt/arc4random.c?rev=1.26&content-type=text/x-cvsweb-markup
> 
> I would move these functions to Cygwin only since they were not present in Newlib.

Done.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature