Re: [PATCH v3 09/24] Feature test macros overhaul: pthread.h

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 15 10:38, Yaakov Selkowitz wrote:
> On 2016-03-15 06:49, Corinna Vinschen wrote:
> >On Mar 14 22:10, Yaakov Selkowitz wrote:
> >>diff --git a/newlib/libc/include/pthread.h b/newlib/libc/include/pthread.h
> >>index 20df8e4..e1de176 100644
> >>--- a/newlib/libc/include/pthread.h
> >>+++ b/newlib/libc/include/pthread.h
> >>@@ -344,7 +344,7 @@ void	_EXFUN(_pthread_cleanup_pop,
> >>      _pthread_cleanup_pop(&_pthread_clup_ctx, (_execute)); \
> >>    } while (0)
> >>
> >>-#if defined(_GNU_SOURCE)
> >>+#if __GNU_VISIBLE
> >>  void	_EXFUN(_pthread_cleanup_push_defer,
> >>  	(struct _pthread_cleanup_context *_context,
> >>  	void (*_routine)(void *), void *_arg));
> >>@@ -362,7 +362,7 @@ void	_EXFUN(_pthread_cleanup_pop_restore,
> >>  #define pthread_cleanup_pop_restore_np(_execute) \
> >>      _pthread_cleanup_pop_restore(&_pthread_clup_ctx, (_execute)); \
> >>    } while (0)
> >>-#endif /* defined(_GNU_SOURCE) */
> >>+#endif /* __GNU_VISIBLE */
> >>
> >>  #if defined(_POSIX_THREAD_CPUTIME)
> >
> >Don't we need this for Cygwin's pthread.h as well?
> 
> Cygwin's pthread.h does not use any feature test macros, nor do we have
> those functions.

Oh, right, we only have _pthread_cleanup_push/pop.  From the glibc
man page it doesn't sound too tricky to add them at one point.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: signature.asc
Description: PGP signature