This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Pre-processor mismatch between [libc/machine/arm] strlen.c and strlen-armv7.s - may lead in duplicate definition

From: Nick Clifton <nickc at redhat dot com>
To: newlib at sourceware dot org, Richard Earnshaw <rearnsha at arm dot com>
Date: Fri, 21 Aug 2015 11:51:58 +0100
Subject: Re: Pre-processor mismatch between [libc/machine/arm] strlen.c and strlen-armv7.s - may lead in duplicate definition
Authentication-results: sourceware.org; auth=none
References: <1701482426 dot 3098447 dot 1438927193663 dot JavaMail dot root at fh-salzburg dot ac dot at> <1035350937 dot 3098567 dot 1438928144851 dot JavaMail dot root at fh-salzburg dot ac dot at> <20150820085645 dot GH30904 at calimero dot vinschen dot de>

Hi Corinna,

Somebody from arm can comment on this, please?


Markus is correct - the parenthesis is needed.

Cheers
  Nick

PS. A better patch would be to define the tests in one place - arm_asm.h- and then check the results in both strlen,c and strlen-armv7.S. Inthat way there would be no need to ensure synchronisation between thesources. But if that is going to be done, then a full cleanup of thecode in the machine/arm directory would probably be in order.


Cheers
  Nick

Follow-Ups:
- Re: Pre-processor mismatch between [libc/machine/arm] strlen.c and strlen-armv7.s - may lead in duplicate definition
  - From: Corinna Vinschen

References:
- Pre-processor mismatch between [libc/machine/arm] strlen.c and strlen-armv7.s - may lead in duplicate definition
  - From: Markus Eisenmann
- Re: Pre-processor mismatch between [libc/machine/arm] strlen.c and strlen-armv7.s - may lead in duplicate definition
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]