This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: [newlib][ARM][PATCH 1/3] Use machine header file for param configuration.
- From: Richard Earnshaw <Richard dot Earnshaw at foss dot arm dot com>
- To: Andre Vieira <Andre dot SimoesDiasVieira at arm dot com>, "newlib at sourceware dot org" <newlib at sourceware dot org>
- Date: Fri, 31 Jul 2015 10:34:24 +0100
- Subject: Re: [newlib][ARM][PATCH 1/3] Use machine header file for param configuration.
- Authentication-results: sourceware.org; auth=none
- References: <55BB3FBD dot 5090609 at arm dot com>
On 31/07/15 10:28, Andre Vieira wrote:
> newlib/ChangeLog:
> 2015-07-28 Andre Vieira <andre.simoesdiasvieira@arm.com>
>
> * libc/sys/arm/sys/param.h: Include machine/param.h
> (HZ, NOFILE, PATHSIZE): Define.
>
> param_refactor_1.patch
>
>
> From abc2d5f3398721f6ca891b9581feaba58730b19c Mon Sep 17 00:00:00 2001
> From: Andre Simoes Dias Vieira <andsim01@arm.com>
> Date: Tue, 28 Jul 2015 12:10:59 +0100
> Subject: [PATCH 1/2] Moved param configuration to machine/param.h
>
> ---
> newlib/libc/sys/arm/sys/param.h | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/newlib/libc/sys/arm/sys/param.h b/newlib/libc/sys/arm/sys/param.h
> index adc066e9a8756e07edaaa8cadc79b5f05c996ac9..622c371972ab3c9dbb93ea5c51323a593e2a171a 100644
> --- a/newlib/libc/sys/arm/sys/param.h
> +++ b/newlib/libc/sys/arm/sys/param.h
> @@ -3,9 +3,17 @@
> #ifndef _SYS_PARAM_H
> # define _SYS_PARAM_H
>
> -# define HZ (100)
> -# define NOFILE (60)
> +#include <machine/param.h>
> +
> +#ifndef HZ
> +# define HZ (60)
Why have you changed the value for HZ? It seems that, by convention,
ARM boards have always used 100.
R.
> +#endif
> +#ifndef NOFILE
> +# define NOFILE>(60)
> +#endif
> +#ifndef PATHSIZE
> # define PATHSIZE (1024)
> +#endif
>
> #define BIG_ENDIAN 4321
> #define LITTLE_ENDIAN 1234
>