This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] string: add GNU basename(3)

From: Mike Frysinger <vapier at gentoo dot org>
To: Yaakov Selkowitz <yselkowi at redhat dot com>
Cc: newlib at sourceware dot org
Date: Fri, 13 Mar 2015 13:33:36 -0400
Subject: Re: [PATCH] string: add GNU basename(3)
Authentication-results: sourceware.org; auth=none
References: <1426263913-6680-1-git-send-email-yselkowi at redhat dot com> <20150313164414 dot GP877 at vapier> <1426265313 dot 16148 dot 9 dot camel at redhat dot com>

On 13 Mar 2015 11:48, Yaakov Selkowitz wrote:
> On Fri, 2015-03-13 at 12:44 -0400, Mike Frysinger wrote:
> > On 13 Mar 2015 11:25, Yaakov Selkowitz wrote:
> > > +char* 
> > 
> > pretty sure newlib follows GNU style which means this code needs a bit of work
> 
> The spacing follows the existing libc/unix/basename.c file, off of which
> this is based.

existing broken files isn't a good reason for adding more ;)
-mike

Attachment: signature.asc
Description: Digital signature

References:
- [PATCH] string: add GNU basename(3)
  - From: Yaakov Selkowitz
- Re: [PATCH] string: add GNU basename(3)
  - From: Mike Frysinger
- Re: [PATCH] string: add GNU basename(3)
  - From: Yaakov Selkowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]