Re: [PATCH 2/2 v2] Merge parts of <sys/time.h> from FreeBSD

[Corinna Vinschen <vinschen at redhat dot com>]

On Mar 12 17:14, Corinna Vinschen wrote:
> On Mar 12 14:17, Sebastian Huber wrote:
> > tklFqMHF5C3moKE+1wx3/zV2VT4pnAu7F
> >  hn1c1+wDWNrqs9dkyEecEH6cqeynx6fnA3DO+aY1cVzw==
> > Status: O
> > Content-Length: 20077
> > Lines: 669
> > 
> > Merge parts of the latest <sys/time.h> from FreeBSD to Newlib.  This has
> > two reasons.
> > 
> > 1. We want to use the FreeBSD timecounters for timekeeping in RTEMS.
> > See also https://devel.rtems.org/ticket/2271.
> > 
> > 2. This makes the port of the network stack from FreeBSD easier.
> 
> This patch breaks Cygwin.  The problem is that the introduction of
> sys/_timeval.h drops the _TIMEVAL_DEFINED guards.  These guards,
> guarding
> 
>   struct timeval
>   timerisset
>   timercmp
>   timerclear
> 
> plus only in newlib
> 
>   timeradd
>   timersub
> 
> are shared with the Mingw-w64 header _timeval.h which defines struct
> timeval slightly differently (thanks, Windows!).  These guards must be
> maintained in the new version, too.
> 
> May I suggest to move the definition of the aforementioned macros into
> the new _timeval.h file, as in Mingw-w64, so as to simplify the guarding?  

Kind of like the attached.


Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: _timeval.h
Description: Text document

Attachment: pgpk2bp1cnG9E.pgp
Description: PGP signature