Re: [PATCH]Fix newlib.wctype/twctrans.c compilation warning: implicit declaration of function 'toupper' & 'tolower'

[Corinna Vinschen <vinschen at redhat dot com>]

On Jan  7 16:53, Renlin Li wrote:
> On 07/01/15 15:47, Eric Blake wrote:
> >On 01/07/2015 06:43 AM, Renlin Li wrote:
> >
> >>Instead, towupper and towloer should be called as wctype.h is included
> >>in the test case.
> >>
> >>newlib regresstion test is done using aarch64-none-elf toolchain, no new
> >>issues.
> >>Is it Okay to commit?
> >>
> >>-  CHECK (towctrans (L'A', x) == tolower ('A'));
> >>-  CHECK (towctrans (L'5', x) == tolower ('5'));
> >>+  CHECK (towctrans (L'A', x) == towlower ('A'));
> >Shouldn't this be using towlower (L'A'), since towlower wants wint_t
> >inputs?  While POSIX requires that 'A' and L'A' have the same integer
> >value, C99 allows for situations where multibyte characters use a
> >different encoding of wint_t than the corresponding 'char' representing
> >the same character.
> >
> Hi Eric,
> 
> Thank you for pointing it out.
> 
> I have updated the patch, newlib regresstion test is done using
> aarch64-none-elf toolchain, no new issues.
> 
> please check the new attachment.

Patch applied.


Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpr6I3NZiLP9.pgp
Description: PGP signature