[ARM] Reorganize memcpy selection.

[Marcus Shawcroft]

On 05/11/15 11:32, Richard Earnshaw wrote:
> On 05/11/15 09:55, Marcus Shawcroft wrote:

>> 2015-11-05  Marcus Shawcroft  <marcus.shawcroft@arm.com>
>>
>>         * libc/machine/arm/Makefile.am: Drop MEMCPY_SRC and MEMCPY_OBJ.
>>         * libc/machine/arm/Makefile.in: Regenerate.
>>         * libc/machine/arm/memcpy-stub.c: New.
>>         * libc/machine/arm/memcpy.c: Adjust copyright year.  Adjust
>>           comments.


>> +#if (defined (__OPTIMIZE_SIZE__) || defined (PREFER_SIZE_OVER_SPEED))
>> +# include "../../string/memcpy.c"
>> +#elif (__ARM_ARCH >= 7 && __ARM_ARCH_PROFILE == 'A' \
>> +       && defined (__ARM_FEATURE_UNALIGNED))
>
> You should include acle-compat.h before testing ACLE macros, so that
> this will work with older GCC.

Done.

>> +/* Defined in memcpy.S.  */
>> +#elif defined (__ARM_ARCH_7M__) || defined (__ARM_ARCH_7EM__)
>
> Ideally these should also be replaced with ACLE style tests.

OK, you are tugging on a long bit of thread here... I've modified this 
one, please eyeball my replacement before I commit it.

This spin of the patch also drops the now disused configure.in tests.

>
> OK with those changes.

Please check my armv7[e]m change looks sane before I commit it...

Cheers
/Marcus

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ARM-Reorganize-memcpy-selection.patch
Type: text/x-patch
Size: 13247 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/newlib/attachments/20151106/14b8444a/attachment.bin>