This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

RE: [PATCH] itoa

From: "Jon Beniston" <jon at beniston dot com>
To: <newlib at sourceware dot org>
Date: Tue, 9 Dec 2014 10:45:18 -0000
Subject: RE: [PATCH] itoa
Authentication-results: sourceware.org; auth=none
References: <000001d01222$7f382b80$7da88280$ at beniston dot com> <20141208171737 dot GX3810 at calimero dot vinschen dot de> <007c01d01312$9aed0cb0$d0c72610$ at beniston dot com> <20141209100702 dot GA16321 at calimero dot vinschen dot de>

Hi Corinna,

> Given that this is non-standard anyway, what about creating a safer 
> alternative instead, along the lines of Craig's/Freddie's itoa_s/np?
>
> Also, shouldn't the functions start with an underscore so as not 
> to pollute the standard namespace?  itoa and utoa are very likely 
> not uncommon as function names in existing projects.

Perhaps. I wrote it so that some existing code would compile though. In stdlib.h, it's in a #ifndef __STRICT_ANSI__ block next to dtoa() et al., which I presume are just as non-standard. 

>> I've also modified it as per Freddie's suggestion.
>
> Did you test it?  AFAICS, the itoa function never returns the sign:

Oops, not Freddie's version. Updated version attached.

Cheers,
Jon

Attachment: itoa3.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH] itoa
  - From: Corinna Vinschen

References:
- [PATCH] itoa
  - From: Jon Beniston
- Re: [PATCH] itoa
  - From: Corinna Vinschen
- RE: [PATCH] itoa
  - From: Jon Beniston
- Re: [PATCH] itoa
  - From: Corinna Vinschen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]