Re: [PATCH] itoa

[Corinna Vinschen <vinschen at redhat dot com>]

Hi Jon,

On Dec  7 13:34, Jon Beniston wrote:
> Hi,
> 
> The attached patch adds support for the itoa and utoa functions, for
> converting integers to strings.
> 
> This is a function that is supported on other platforms,

What other platforms?  It appears in K&R, base 10 only, and it appears
in a Unix manual from 1971(*), but I can't find it in GLibc nor one of
the BSDs.

The API is rather unsafe, given that the size of the buffer is not
checked (no size parameter).  But what I'm really missing are checks for
the base parameter being valid.  It could be > 36.  Or negative.

I see how this may be useful for embedded targets, but in a standard C
library, I'm not so sure about.


Corinna

(*) http://en.wikibooks.org/wiki/C_Programming/C_Reference/stdlib.h/itoa

-- 
Corinna Vinschen
Cygwin Maintainer
Red Hat

Attachment: pgpIUHO55NsFw.pgp
Description: PGP signature