This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH Newlib]Dont inline std when optimizing for size


On Thu, Dec 12, 2013 at 4:15 PM,  <pinskia@gmail.com> wrote:
>
>
>> On Dec 11, 2013, at 11:47 PM, "bin.cheng" <bin.cheng@arm.com> wrote:
>>
>> Hi,
>> This is just a pickup in newlib.  It specifies _NOINLINE_STATIC for std
>> since some version (4_8) GCC may inline this function even when we are
>> compiling for Os.
>> This is mainly a gcc problem and I have filed
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59479 for GCC.
>>
>> Meanwhile, I think this is also wanted in Newlib, is it OK?
>
> Is it a size win on other targets like MIPS or PowerPC?
I will check it on MIPS/PowerPC, I think there will be benefit since
the function is inlined three times in __sinit.

Thanks,
bin

>
> Thanks,
> Andrew
>
>
>>
>> Thanks,
>> bin
>>
>> 2013-12-12  Bin Cheng  <bin.cheng@arm.com>
>>
>>    * libc/stdio/findfp.c (std): Don't inline when optimizing
>>    for code size.
>> <no-inline-std-20131212.txt>



-- 
Regards.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]