This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] ARM: Fix strcmp() for Thumb-1

From: Richard Earnshaw <rearnsha at arm dot com>
To: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
Cc: "newlib at sourceware dot org" <newlib at sourceware dot org>
Date: Tue, 28 May 2013 10:36:53 +0100
Subject: Re: [PATCH] ARM: Fix strcmp() for Thumb-1
References: <1369567629-11768-1-git-send-email-sebastian dot huber at embedded-brains dot de> <CAHFci29SAYS38Fw57ZvkWZ0KcUFpJzG5k9Tk-tgC0yMQHDWY1A at mail dot gmail dot com> <51A30453 dot 5070204 at embedded-brains dot de>

On 27/05/13 07:59, Sebastian Huber wrote:

On 05/27/2013 04:18 AM, Bin.Cheng wrote:
[...]

Though I have no right to approve the patch, I would like to have below comment.
UAL is generally preferred, thus you may handle armv6-m specially by
keeping UAL for it. For example,

#if (defined(__thumb__) && defined(__ARM_ARCH_6M__))
//...
#endif


Which problem does this additional pre-processor complexity solve?  The
generated machine code is the same.

I don't think either patch is correct. Instead we should explicitlymark the attributes in this case, probably as follows, but I've onlysmoke tested this.


Sebastian, does this fix your problem?

R.

Attachment: strcmp-attr.patch
Description: Text document

Follow-Ups:
- Re: [PATCH] ARM: Fix strcmp() for Thumb-1
  - From: Sebastian Huber

References:
- [PATCH] ARM: Fix strcmp() for Thumb-1
  - From: Sebastian Huber
- Re: [PATCH] ARM: Fix strcmp() for Thumb-1
  - From: Bin.Cheng
- Re: [PATCH] ARM: Fix strcmp() for Thumb-1
  - From: Sebastian Huber

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]