Re: [PATCH CR16] Added some missing instructions

[Corinna Vinschen <vinschen at redhat dot com>]

On May  4 09:43, Sandeep Kumar Singh wrote:
> Hi Corinna,
> 
> >> Can you please explain the background why instructions, which were 
> >> supposedly available since 2010 are suddenly "unsupported"?
> 
> CR16 port of Newlib was developed with taking references from existing CRX 
> port. These two National semiconductor targets have many architectural 
> similarities, among them include very similar instruction set.
> 
> I am sure because of this, when asm.h was included in the initial Newlib port
> of CR16 it was taken as is from CRX port. However, recently we found some of 
> the instructions supported by CR16, were missing in this file viz. lpr, lprd, 
> spr, sprd.
> 
> While adding these instructions in asm.h, we also found it has few other CRX 
> instructions which are not supported by CR16. Hence in the same patch, we are
> removing these unsupported instructions.
> 
> >> Wouldn't that potentially break existing code?
> 
> I believe it should not break existing code, as these instructions are not 
> supported by the CR16 architecture.

Thanks.  Patch applied.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat