Re: RTEMS utime.h is broken

[Ralf Corsepius <ralf dot corsepius at rtems dot org>]

On 02/09/2012 02:12 PM, Corinna Vinschen wrote:
> On Feb  9 06:04, Joel Sherrill wrote:
> > No. It looks correct to me if you agree. Just a discrepancy with the standard.
> >
> > --joel
> >
> > Corinna Vinschen<...>  wrote:
> >
> > > On Feb  1 16:10, Sebastian Huber wrote:
> > > > Hello,
> > > >
> > > > according to
> > > >
> > > > http://pubs.opengroup.org/onlinepubs/009604599/functions/utime.html
> > > >
> > > > #include<utime.h>
> > > >
> > > > should work without preceding includes.  The RTEMS utime.h lacks an
> > > > include of<sys/types.h>.
> > > > [...]
> > > > 2012-02-01  Sebastian Huber<...>
> > > >
> > > > 	* libc/sys/rtems/sys/utime.h: Include<sys/types.h>  to provide a
> > > > 	definition of time_h.
> > > >
> > > > Index: ./libc/sys/rtems/sys/utime.h
> > > > ===================================================================
> > > > RCS file: /cvs/src/src/newlib/libc/sys/rtems/sys/utime.h,v
> > > > retrieving revision 1.1
> > > > diff -u -r1.1 utime.h
> > > > --- ./libc/sys/rtems/sys/utime.h	7 Nov 2002 19:27:36 -0000	1.1
> > > > +++ ./libc/sys/rtems/sys/utime.h	1 Feb 2012 15:07:47 -0000
> > > > @@ -5,6 +5,8 @@
> > > >   #ifndef __UTIME_h__
> > > >   #define __UTIME_h__
> > > >
> > > > +#include<sys/types.h>
> > > > +
> > > >   #ifdef __cplusplus
> > > >   extern "C" {
> > > >   #endif
> > >
> > > Any comment from the RTEMS folks?
>
> Thanks, I applied the patch.

The changelog entry contains a typo.

It should have been
... definition of time_t.
instead of
... definition of time_h.

Ralf