Re: [RFA] strftime: Add POSIX flags, width, and handling for E and O modifier

[Corinna Vinschen <vinschen at redhat dot com>]

On Feb 24 14:17, Jeff Johnston wrote:
> On 22/02/10 08:59 AM, Corinna Vinschen wrote:
> >Hi,
> >
> >below is a rather big patch to libc/time/strftime.c.  It reworks
> >strftime and wcsftime to accomplish the following:
> >
> >- Add the POSIX-1.2008 '0' and '+' padding flags
> >
> >- Add a minimal field width specifier, also according to POSIX-1.2008.
> >
> >- Add handling for E modifier to allow era specific date and time
> >   printing in locales supporting eras.  Along the POSIX-1.2008
> >   definition the E modifier is only supported for the c, C, x, X, y, and
> >   Y conversion specifiers.
> >
> >- Add handling for O modifier to allow printing of values using
> >   alternative digits in locales supporting that.  Along the POSIX-1.2008
> >   definition the O modifier is only supported for the d, e, H, I, m, M,
> >   S, u, U, V, w, W, and y conversion specifiers.
> >[...]
> >Ok to apply?
> 
> Yes.  If you can cordone off major functional sections using a flag
> to save space for cross-platforms that are ok with current
> functionality: e.g. #ifdef __POSIX_2008_STRFTIME__, that would be
> helpful.

Thanks for the review.  I will rework the patch to fence off the new
code using the above flag.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat