This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
Re: KOI8 character sets
- From: Jeff Johnston <jjohnstn at redhat dot com>
- To: Andy Koppe <andy dot koppe at gmail dot com>
- Cc: newlib at sourceware dot org
- Date: Tue, 25 Aug 2009 12:58:04 -0400 (EDT)
- Subject: Re: KOI8 character sets
Andy,
The fix to sb_charsets.c is correct but the old comment was fine.
Can the CP numbers be used directly? You set the charset for KOI8 to
one of two CP values. Can a user specify those numbers directly as they
can for example, CP1258? If it should be yes, please add the missing
cases to the CP case statement in locale.c, otherwise, I'll check these fixes in with
the modified comment.
-- Jeff J.
----- Original Message -----
From: "Andy Koppe" <andy.koppe@gmail.com>
To: newlib@sourceware.org
Sent: Tuesday, August 25, 2009 2:30:38 AM GMT -05:00 US/Canada Eastern
Subject: Re: KOI8 character sets
2009/8/24 Jeff Johnston:
> Andy's patch checked in with Corinna's documentation change as well. ÂI
> changed the documentation
> content to just state <<EUCJP>> and not <<EUCJP>>/<<eucJP>> and later on I
> used EUCJP and eucJP
> as an example of case-insensitivity rather than UTF-8. ÂThis made it easier
> to apply the doc patch and it made it clear that eucJP was still valid.
Thanks!
Unfortunately I found a couple of problems with it, which mean that
conversion back from wchar to KOI8 doesn't work. Sorry 'bout that. Fix
attached.
ChangeLog:
* libc/stdlib/sb_charsets.c (__micro_atoi): Allow five-digit codepage numbers.
* libc/locale/locale.c (loadlocale): Set MB_CUR_MAX to 1 for KOI8 charsets.
* libc/stdlib/local.h (__cp_conv): Remove incorrect number of codepages.
Andy