This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix UTF-16 surrogate handling in __utf8_mbtowc

From: Corinna Vinschen <vinschen at redhat dot com>
To: newlib at sourceware dot org
Date: Tue, 28 Jul 2009 21:59:16 +0200
Subject: Re: [PATCH] Fix UTF-16 surrogate handling in __utf8_mbtowc
References: <20090728165730.GV18621@calimero.vinschen.de> <416096c60907281134m36257209m4206737e05dc48e6@mail.gmail.com>
Reply-to: newlib at sourceware dot org

On Jul 28 19:34, Andy Koppe wrote:
> 2009/7/28 Corinna Vinschen:
> > +         *pwc = 0xdc00 | ((tmp - 0x10000) & 0x3ff);
> 
> Nitpicking: The '- 0x10000' isn't necessary here; '(tmp & 0x3ff)' should do.

Right, thanks for the hint.  I've changed that locally.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat

References:
- [PATCH] Fix UTF-16 surrogate handling in __utf8_mbtowc
  - From: Corinna Vinschen
- Re: [PATCH] Fix UTF-16 surrogate handling in __utf8_mbtowc
  - From: Andy Koppe

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]