This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] Add CJK ambiguous character handling dependent on language


Corinna Vinschen wrote:
On Jun 4 02:56, IWAMURO Motonori wrote:
2009/6/3 Corinna Vinschen <vinschen@redhat.com>:
Hi,

as discussed three weeks ago, I'll now propose the following patch.  It
changes __wcwidth along the lines of Markus Kuhn's code and Iwamuro
Motonori's proposal to use the language set via setlocale(1) to return
different character widths for the CJK Ambiguous Width" category of
characters.  Tested on Cygwin.

Ok to apply?
It looks good.
But I don't think that the test order is good for the performance.
How about the following code?

Good idea. I'll change that in my local patch accordingly.



Thanks, Corinna

Feel free to commit that when you are done and have tested.

-- Jeff J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]