This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Various cleanups


     I just did a little bit of cleanup, mostly getting rid of compiler
warnings.  In doing so I found some mistakes or oversights that I also
cleaned up.  The descriptions are in the ChangeLog portion of the
attached patch file.
     There are a couple other things that I noted but did not fix,
pending
getting someone to help answer some questions:

1)  libc/stdio/mktemp.c calls _stat64_r(), but _stat64_r() does not
appear anywhere except in mktemp.c; it appears to be missing.  It seems
that the solution is to create reent/stat64r.c (by analogy with
_fstat64_r()).
Is this the right solution, or should something else be done?

2)  libc/search/hash_func.c defines four hash functions, hash1 through
hash4.  They are declared static.  1-3 are not used.  Since they are
static, it would appear that they are therefore completely worthless as
it is impossible to access them.
Should they just be commented out?

Craig

Attachment: misc.patch
Description: misc.patch


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]