Re: [patch/RFA] New functions wcpcpy/wcpncpy

[Lars Johannsen <mail at lars-johannsen dot dk>]

On Wed, 19 Dec 2007 12:28:03 -0500, Jeff Johnston
<jjohnstn@redhat.com> wrote:

Re: 1.16.0 tar-ball, error in libc/string/Makefile.am, see below

>Corinna Vinschen wrote:
>> Hi,
>> 
>> below is my implementation of wcpcpy and wcpncpy.  As their single
>> byte counterparts stpcpy and stpncpy, both functions are candidates
>> for inclusion into POSIX and SUSv4.  I tested the implementation
>> under Cygwin.
>> 
>> Ok to apply?
>
>Yes, go ahead.
>
>-- Jeff J.
>> 
>> Thanks,
>> Corinna
>> 
>> 
>> 	* libc/include/wchar.h: Add prototypes for wcpcpy and wcpncpy.
>> 	* libc/string/Makefile.am (ELIX_SOURCES): Add wcpcpy.c and
>> 	wcpncpy.c.
>> 	(CHEWOUT_FILES): Add wcpcpy.def and wcpncpy.def.
>> 	* libc/string/Makefile.in: Regenerate.
>> 	* libc/string/wcpcpy.c: New file.
>> 	* libc/string/wcpncpy.c: New file.
>> 	* libc/string/wcstrings.tex: Add wcpcpy and wcpncpy.
>> 
>>  
>> Index: libc/include/wchar.h
>> ===================================================================
>> RCS file: /cvs/src/src/newlib/libc/include/wchar.h,v
....
>> Index: libc/string/Makefile.am
>> ===================================================================
>> RCS file: /cvs/src/src/newlib/libc/string/Makefile.am,v
>> retrieving revision 1.18
>> diff -u -p -r1.18 Makefile.am
>> --- libc/string/Makefile.am	4 Jul 2007 16:18:34 -0000	1.18
>> +++ libc/string/Makefile.am	19 Dec 2007 17:14:43 -0000
>> @@ -82,7 +82,9 @@ ELIX_SOURCES = \
>>  	stpncpy.c \
>>  	strndup.c \
>>  	strcasestr.c \
>> -	strndup_r.c
>> +	strndup_r.c \
>> +	wcpcpy.c \
>> +	wcpncpy.c \
>>  endif
                ^^
FYI:
That last slash gives me a "unterminated conditionals error"
when i run automake (v1.9.6) in libc.
It is there in the 1.16.0-tarball, but has been fixed by the
changes in cvs rev-1.21
>>  
>>  libstring_la_LDFLAGS = -Xcompiler -nostdlib
...
>> 
>
Regards
 LArs