This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: *printf_r and reentrancy


Eric Blake wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jeff Johnston on 3/14/2007 12:17 PM:
A simple fix to this problem is to add a check for the fake file
structures in fflush (_REENT_SMALL only) and return immediately without
doing anything.  The CHECK_INIT macro for _REENT_SMALL should be altered
to use the std streams for the given reentrancy struct when reassigning
the file pointer.

Could you handle that, then, since you know more about using _REENT_SMALL?



Ok.


Meanwhile, here's a patch that should be ready to apply, to fix up
malloc failure with asprintf, and the followon reentrancy fix to any
of the stdio files that used malloc/free via __smakebuf.  Tested by
compiling and running cygwin, although it is rather hard testing
malloc failure, so a double-check wouldn't hurt.

2007-03-13 Eric Blake <ebb9@byu.net>

* libc/stdio/local.h (cantwrite, FREEUB, FREELB): Make reentrant.
...

Any word on whether this patch will be applied?


Done.


-- Jeff J.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             ebb9@byu.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF+Ue084KuGfSFAYARAtjoAJ94sEJaIXyBfHfJsKItu8DkE/KO5ACeMuBZ
bq1FgEeJFI+4i7ido+IqHJE=
=BtkA
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]