This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add base fenv and spu fenv support


Patrick Mansfield wrote:
Attached is a repost of the spu fenv patches rolled into one patch, with
the following changes since the last posting:

- Rebase against current cvs (avoid rejection in configure.host)

- Add missing #include <fenv.h> in fe_dfl_fenv.c

- Add __cplusplus wrappers in fenv.h

- Use _EXFUN in fenv.h

- Add #ifndef _FENV_H and #ifndef _SYS_FENV_H wrappers

Jeff can you comment or apply?


1. Why are you using "../headers" in your C files when the C files and "headers" subdirectory are in the same directory? 2. There is an explicit copyright in sys/fenv.h but no license. 3. I do not see any real advantage to having the fenv.h in the main include directory since it only declares std prototypes, doesn't work for any platform but spu and has a documentation clause. At this time, it would be best to just place it in machine/spu/include

-- Jeff J.




Thanks ...

-- Patrick Mansfield


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]