This is the mail archive of the
newlib@sourceware.org
mailing list for the newlib project.
[sjackman@gmail.com: Re: libgloss psignal declaration [PATCH]]
- From: DJ Delorie <dj at redhat dot com>
- To: newlib at sourceware dot org
- Date: Tue, 21 Mar 2006 19:22:11 -0500
- Subject: [sjackman@gmail.com: Re: libgloss psignal declaration [PATCH]]
Comments from the newlib side about this approach?
------- Start of forwarded message -------
X-Sieve: CMU Sieve 2.2
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
s=beta; d=gmail.com;
h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
b=fzj5hyIJGsoCm/7+QqxnI5gWxQ6F/zOQvd1g6nL8wWTYfs17KKniFdmrcir0SsJpcVks4M/DnKqxu8fBudqkUCiUB7Ks/PDUEjynHbU0snyl+2fhKinCOyIt3Qxa3GjIXc145BS8AtSdGDz9u9+Q5x3A58sI38Ipmf92CkJuQw8=
Date: Tue, 21 Mar 2006 17:16:27 -0700
From: "Shaun Jackman" <sjackman@gmail.com>
Reply-To: "Shaun Jackman" <sjackman@gmail.com>
To: "DJ Delorie" <dj@redhat.com>
Subject: Re: libgloss psignal declaration [PATCH]
Cc: gcc-patches@gcc.gnu.org
In-Reply-To: <200510262319.j9QNJUjC029181@greed.delorie.com>
Content-Disposition: inline
X-RedHat-Spam-Score: -2.796
X-MIME-Autoconverted: from base64 to 8bit by greed.delorie.com id k2M0K9gu031660
On 10/26/05, DJ Delorie <dj@redhat.com> wrote:
> > I found the following patch necessary to build libiberty with newlib
> > headers. Although, glibc seems to use the same signature now.
>
> While I'm generally OK with this...
...
> 3. If you have a psignal prototype, you should have a psignal
> function, and thus should not be compiling this code at all. Thus,
> something else is broken. Look for newlib-specific code in
> configure.ac.
>
> I suggest leaving the prototype as-is until #3 is resolved, since the
> conflict tells you when it's still broken.
Since some targets may provide a particular function, and some may
not, the trend in newlib has been to supply complete headers
regardless of the target's completeness. If I add the missing
documentation, would this patch be accepted?
Cheers,
Shaun
2005-10-26 Shaun Jackman <sjackman@gmail.com>
* libiberty/strsignal.c (psignal): Change the signo parameter from
unsigned to int, and message from char * to const char *.
Index: libiberty/strsignal.c
===================================================================
RCS file: /cvs/src/src/libiberty/strsignal.c,v
retrieving revision 1.9
diff -u -r1.9 strsignal.c
- --- libiberty/strsignal.c 28 Mar 2005 02:09:01 -0000 1.9
+++ libiberty/strsignal.c 26 Oct 2005 21:56:29 -0000
@@ -549,7 +549,7 @@
#ifndef HAVE_PSIGNAL
void
- -psignal (unsigned signo, char *message)
+psignal (int signo, const char *message)
{
if (signal_names == NULL)
{
------- End of forwarded message -------