This is the mail archive of the newlib@sourceware.org mailing list for the newlib project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libgloss/arm: isatty [PATCH]

Hi Shaun,

+     /* GDB does not yet support the IsTTY SWI that _isatty
+      * calls, so always return true for now. */

                                                 ^
Minor point: You should have two spaces at the   |  end of a comment.


I haven't run into this before. You're suggesting two spaces between
the final period and the asterisk? I'm curious as to why.

Because:

  A. It is in the GNU Coding standards:
     http://www.gnu.org/prep/standards/standards.html#Comments

       "Please put two spaces after the end of a sentence in
        your comments, so that the Emacs sentence commands
        will work."

  B. It is consistent with how comments are formated in (most of) the
     rest of the binutils/gcc/newlib sources.

Cheers
  Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]