On Mon, Jun 28, 2004 at 08:45:43PM -0400, Christopher Faylor wrote:
On Mon, Jun 28, 2004 at 08:31:14PM -0400, Jeff Johnston wrote:
I have a number of concerns with the patch you have submitted, but no
objections to the concept.
First of all, if you go around changing acinclude.m4, then "all" aclocal.m4
files and configure files have to be regenerated in the newlib directory.
Second, if you can, please use aclocal-1.4-p6 so as to minimize changes
being introduced.
I'll try to track that version down.
Thirdly, the code moved to acinclude.m4 won't work for lower level
directories because it is using `pwd` which will change the targ-include
directory every time.
Isn't newlib_basedir set to the top level of newlib by every package?
It sure seems like that is what is going on in all of the sub-configures.
If so, then this:
abs_newlib_basedir=`cd ${newlib_basedir} && pwd`
should always equate to the same thing no matter where it's run. In
the subjdirectories, it will just get rid of trailing ..'s which bring
you back to the top.
It's been a long time since I sent the above mail but this problem just
bit me again so I thought I'd dust out the patch that I had sitting
around and see if I could clean it up for resubmission.
Unfortunately, somewhere along the line, I ended up wiping out my work with
an injudicious use of "cvs update" so I had to start from scratch. I used
a different, maybe less intrusive technique this time.
Since this is now entirely cygwin-specific, I thought about just checking it
in as is, but I thought I could conceivably be breaking some convention by
setting CC the way this patch does so thought I would check to see if this
method was ok. If not, I'll try to resurrect some recollection of what I
did before.
Is this ok to check in?
cgf
2005-03-23 Christopher Faylor <cgf@timesys.com>
* configure.host: For cygwin, redefine CC with cygwin include directory
first to mimic the behavior of the top-level configury. Move include
directory out of newlib_cflags.
Index: configure.host
===================================================================
RCS file: /cvs/uberbaum/newlib/configure.host,v
retrieving revision 1.69
diff -u -p -r1.69 configure.host
--- configure.host 22 Mar 2005 23:45:42 -0000 1.69
+++ configure.host 23 Mar 2005 05:07:30 -0000
@@ -455,7 +455,8 @@ case "${host}" in
default_newlib_io_long_long="yes"
default_newlib_io_long_double="yes"
default_newlib_io_pos_args="yes"
- newlib_cflags="${newlib_cflags} -DHAVE_OPENDIR -DHAVE_RENAME -DSIGNAL_PROVIDED -D_COMPILING_NEWLIB -DHAVE_FCNTL -DMALLOC_PROVIDED -I${cygwin_srcdir}/include"
+ CC="${CC} -I${cygwin_srcdir}/include"
+ newlib_cflags="${newlib_cflags} -DHAVE_OPENDIR -DHAVE_RENAME -DSIGNAL_PROVIDED -D_COMPILING_NEWLIB -DHAVE_FCNTL -DMALLOC_PROVIDED"
syscall_dir=syscalls
;;
# RTEMS supplies its own versions of some routines: