This is the mail archive of the newlib@sources.redhat.com mailing list for the newlib project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RTEMS patch sweep: bogus implicit int32 in libm

From: Jeff Johnston <jjohnstn at redhat dot com>
To: Ralf Corsepius <ralf dot corsepius at rtems dot org>
Cc: Newlib List <newlib at sources dot redhat dot com>, Joel Sherrill <joel dot sherrill at OARcorp dot com>, Eric Norum <norume at aps dot anl dot gov>, Chris Johns <chrisj at rtems dot org>
Date: Thu, 24 Feb 2005 14:04:31 -0500
Subject: Re: RTEMS patch sweep: bogus implicit int32 in libm
References: <1109235028.15959.138.camel@mccallum.corsepiu.local>

Patch checked in, thanks. I modified it slightly to use __uint32_t for all the ints you replaced (as opposed to __int32_t).

-- Jeff J.

Ralf Corsepius wrote:

Hi,

Yet another RTEMS patch ...

The patch below is supposed to fix this bug below, gcc-4.0 reveals for some multilib variants of the h8300 (probably for the avr, too). For these targets, sizeof(int) == 16bit, not 32bit as the code in newlib implicitly assumes.

/users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/gcc/xgcc -B/users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/gcc/ -nostdinc -B/users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/h8300-rtems4.7/newlib/ -isystem /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/build/h8300-rtems4.7/newlib/targ-include -isystem /users/rtems/src/rpms/BUILD/rtems-4.7-h8300-rtems4.7-gcc-newlib-gcc4.0.0newlib1.13.0/gcc-4.0.0/newlib/libc/include -B/opt/rtems-4.7/h8300-rtems4.7/bin/ -B/opt/rtems-4.7/h8300-rtems4.7/lib/ -isystem /opt/rtems-4.7/h8300-rtems4.7/include -isystem /opt/rtems-4.7/h8300-rtems4.7/sys-include -DPACKAGE=\"newlib\" -DVERSION=\"1.13.0\" -I. -I../../../../../gcc-4.0.0/newlib/libm/common -O2 -DHAVE_GETTIMEOFDAY -DMALLOC_PROVIDED -DEXIT_PROVIDED -DMISSING_SYSCALL_NAMES -DSIGNAL_PROVIDED -DREENTRANT_SYSCALLS_PROVIDED -DHAVE_OP

ENDIR -DNO_EXEC -DHAVE_FCNTL -fno-builtin -O2 -g -O2 -c ../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c

../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c: In function '__fpclassifyf':
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:16: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:18: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:18: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:19: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:19: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:21: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:22: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:22: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:24: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:24: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c: In function '__fpclassifyd':
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:38: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:40: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:40: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:41: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:41: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:43: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:44: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:44: warning: comparison is always true due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:47: warning: comparison is always false due to limited range of data type
../../../../../gcc-4.0.0/newlib/libm/common/s_fpclassify.c:48: warning: comparison is always false due to limited range of data type

Ralf

Follow-Ups:
- Re: RTEMS patch sweep: bogus implicit int32 in libm
  - From: Ralf Corsepius

References:
- RTEMS patch sweep: bogus implicit int32 in libm
  - From: Ralf Corsepius

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]